Skip to content

chore(deps): bump com.puppycrawl.tools:checkstyle from 13.4.2 to 14.3.0 - #438

Open
dependabot[bot] wants to merge 3 commits into
mainfrom
dependabot/maven/com.puppycrawl.tools-checkstyle-14.3.0
Open

chore(deps): bump com.puppycrawl.tools:checkstyle from 13.4.2 to 14.3.0#438
dependabot[bot] wants to merge 3 commits into
mainfrom
dependabot/maven/com.puppycrawl.tools-checkstyle-14.3.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 4, 2026

Copy link
Copy Markdown
Contributor

Bumps com.puppycrawl.tools:checkstyle from 13.4.2 to 14.3.0.

Release notes

Sourced from com.puppycrawl.tools:checkstyle's releases.

checkstyle-14.3.0

Checkstyle 14.3.0 - https://checkstyle.org/releasenotes.html#Release_14.3.0

New:

#14120 - Make Checkstyle an java module with module-info.java.

checkstyle-14.2.0

Checkstyle 14.2.0 - https://checkstyle.org/releasenotes.html#Release_14.2.0

New:

#19513 - ModifiedOrder: New property modifierOrder. #17723 - WhitespaceAfter: new token SINGLE_LINE_COMMENT to catch missing whitespace checks around // comments. #8312 - NoWhitespaceAfter: Allow for use of DO_WHILE, LITERAL_CATCH, LITERAL_FOR, LITERAL_IF, and LITERAL_WHILE. #17172 - AnnotationLocation new token MODULE_DEF. Google-style: incomplete coverage on annotation rules for modules. #14986 - New Check UnnecessaryPermitsClause. #7541 - new Check: GoolgeRightCurly. #19949 - New check: JavadocSeeTagOrder. #20639 - new Check: OpenjdkMethodThrowsAlignment.

Bug fixes:

#17663 - Indentation: missing violations for '->' and ',' in return statement continuation. #20541 - False Positive: Lambda is incorrectly flaged by OperatorWrap. #21739 - UnusedLocalVariable: false positive on unnamed variable _ inside anonymous class. #21613 - False negative: UnusedTryResourceShouldBeUnnamed treats same-named identifiers in catch/finally blocks as resource usage. #21695 - openjdk style: use custon modifierOrder at RedundantModifier. #21689 - Add GoogleRightCurly to google_checks.xml instead of RightCurly. #10924 - All checks that use AbstractCheck#getLine() should check code points instead of characters for spacing. #21139 - Performance: Avoid duplicate regex match in SuppressFilterElement.isFileMatch. #21528 - Add checks for Sun Style [4.2 - Wrapping Lines]. #21578 - False Negative: LambdaParameterName silently passes lambdas in switch rule. #21579 - False Negative: NeedBraces silently passes lambdas in switch rule. #5895 - CLI XML output file: file stops dead when an execption occurs. #11410 - False Negative: LeftCurlyCheck. #21583 - Update Documentation Comments Style Guide: add JavadocSeeTagOrder. #21609 - NPE in RightCurlyCheck. #19724 - google_checks.xml: JavadocMethod accessModifiers should include protected to match MissingJavadocMethod scope. #20963 - False negative in LeftCurly for types with option=eol. #21547 - add OpenjdkMethodThrowsAlignment check in openjdk_checks.xml. #20636 - False negatives regarding LeftCurly in openjdk_checks.xml. #17170 - Google-style: unfollowed rule on ordering and spacing of module directives. #21454 - google_checks.xml: false negative 4.3 One statement per line. #21501 - CommonUtil.getFileExtension includes parent-directory dots in the extension. #21445 - google_checks.xml: false negative 3.3.1.1 No module imports. #21477 - Add checks for Sun Style [4.1 - Line Length]. #21444 - google_checks.xml: false negative 3.2 Package declaration.

... (truncated)

Commits
  • bc58fc6 [maven-release-plugin] prepare release checkstyle-14.3.0
  • 5711c72 doc: release notes for 14.3.0
  • 4b8a5b3 minor: Bump version to 14.3.0-SNAPSHOT
  • a93f8f2 Issue #14120: add module-info.java to make Checkstyle an explicit Java module
  • 9e3482f [maven-release-plugin] prepare for next development iteration
  • 6a200bc [maven-release-plugin] prepare release checkstyle-14.2.0
  • 2d2b135 doc: release notes for 14.2.0
  • 194e7a2 Issue #20590: Improve Input coverage for compact sources for SuperCloneCheck
  • 123f477 Issue #17663: Indentation: missing violations for '->' and ',' in return stat...
  • 4b2f353 Issue #20541: fix OperatorWrap false positive for lambda with block body
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
chore(deps): bump com.puppycrawl.tools:checkstyle from 13.4.2 to 14.3.0
1c33c90 
Bumps [com.puppycrawl.tools:checkstyle](https://github.com/checkstyle/checkstyle) from 13.4.2 to 14.3.0.
- [Release notes](https://github.com/checkstyle/checkstyle/releases)
- [Commits](checkstyle/checkstyle@checkstyle-13.4.2...checkstyle-14.3.0)

---
updated-dependencies:
- dependency-name: com.puppycrawl.tools:checkstyle
  dependency-version: 14.3.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file java Pull requests that update java code labels Oct 4, 2026
@dependabot dependabot Bot mentioned this pull request Oct 4, 2026
Closed
@bramp

bramp commented Oct 10, 2026

Copy link
Copy Markdown
Owner

@copilot please fix the style issues, without breaking the public API. So not most likely allowing a few exceptions to the naming scheme

@bramp
Add style-compliant API aliases
ce5dbff 
Co-authored-by: bramp <160627+bramp@users.noreply.github.com>

Copilot AI commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

@copilot please fix the style issues, without breaking the public API. So not most likely allowing a few exceptions to the naming scheme

Added Google-style alternatives and retained the existing public methods as compatibility aliases; internal calls preserve legacy override dispatch. Formatting and Checkstyle pass, and 87 focused tests pass. Commit: ce5dbff.

Copilot AI requested a review from bramp October 10, 2026 01:28
bramp
bramp reviewed Oct 10, 2026
View reviewed changes

@bramp bramp left a comment •
edited
Loading

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot This looks reasonable, but two questions,

Is it worth adding the wrapper method? Should we accept the bad names? And if we do accept the wrapper method should the old names be marked deprecated?

Copilot AI requested a review from bramp October 11, 2026 18:19
@bramp
Remove style-only API wrappers
1cc6e5c 
Co-authored-by: bramp <160627+bramp@users.noreply.github.com>

Copilot AI commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

@copilot please fix the style issues, without breaking the public API. So not most likely allowing a few exceptions to the naming scheme

Removed the additional public wrappers and restored the established API methods; their names now have targeted Checkstyle exemptions. Formatting and Checkstyle pass, and 87 focused tests pass. Commit: 1cc6e5c.

bramp
bramp requested changes Oct 11, 2026
View reviewed changes

@bramp bramp left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is still not correct. Keep the public API names how there were originally. And just exclude them from the style checks.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bramp bramp bramp requested changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file java Pull requests that update java code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bramp